Re: [PATCH v3 5/5] archive-zip: support files bigger than 4GB

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2017, 04:46 UTC
Message-ID: <xmqq7f29w0uj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <e53f1d3f-be3a-ac28-89eb-63011da64586@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 10 quoted lines

> diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh
> index 0ac94b5cc9..a6875dfdb1 100755
> --- a/t/t5004-archive-corner-cases.sh
> +++ b/t/t5004-archive-corner-cases.sh
> @@ -178,7 +178,7 @@ test_expect_success EXPENSIVE,UNZIP 'zip archive bigger than 4GB' '
>  	"$GIT_UNZIP" -t many-big.zip
>  '
>  
> -test_expect_failure EXPENSIVE,UNZIP 'zip archive with files bigger than 4GB' '
> +test_expect_success EXPENSIVE,UNZIP,ZIPINFO 'zip archive with files bigger than 4GB' '

This is a bit curious, as 1/5 adds this test that expects a failure with three prerequisites already. I'll assume that this is a rebase glitch and the preimage actually must have ,ZIPINFO there already.

>  	# Pack created with:
>  	#   dd if=/dev/zero of=file bs=1M count=4100 && git hash-object -w file
>  	mkdir -p .git/objects/pack &&