Re: [PATCH v3 0/5] archive-zip: support files and archives bigger than 4GB

From: René Scharfe <l.s.r@web.de>
Date: Apr 30, 2017, 16:40 UTC
Message-ID: <d1cea1c3-f974-c839-dbdd-5bc95756be84@web.de>
In-Reply-To: <9f6cb421-db61-51ca-6a4b-ea7c94bd513e@kdbg.org>

Am 30.04.2017 um 18:32 schrieb Johannes Sixt:

Show 12 quoted lines

> Am 30.04.2017 um 09:53 schrieb René Scharfe:
>> @@ -178,7 +182,8 @@ test_expect_success EXPENSIVE,UNZIP 'zip archive 
>> bigger than 4GB' '
>>      "$GIT_UNZIP" -t many-big.zip
>>  '
>>
>> -test_expect_success EXPENSIVE,UNZIP,ZIPINFO 'zip archive with files 
>> bigger than 4GB' '
>> +test_expect_success 
>> EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \
> 
> Why is LONG_IS_64BIT required?

Blob sizes are kept in variables of type unsigned long. 64 bits are required to store file sizes bigger than 4GB, and this test is about such a file. A 32-bit git can't use the pack we supply the test file in, so we have to skip this test.

Show 9 quoted lines

>> +    'zip archive with files bigger than 4GB' '
>>      # Pack created with:
>>      #   dd if=/dev/zero of=file bs=1M count=4100 && git hash-object 
>> -w file
>>      mkdir -p .git/objects/pack &&
>>
> 
> -- Hannes
>