Re: Not translatable strings in Git

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2017, 04:31 UTC
Message-ID: <xmqq7f1q4pn8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170509040722.dd2yt4254g3raeev@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I don't think the diffstat summary is marked for translation at all,
> plumbing or not.  There's some history there:
>
>   http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u

Wow, that's a long thread.

Show 6 quoted lines

> There was an attempt to re-enable it for local-only commands:
>
>   http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/
>
> but nobody seems to have responded (I don't have much of an opinion
> myself).

I still think that the latter is wrong, especially the part that touches log-tree.c, pp_header(), and other lower level things that will be read and interpreted by scripts. The change to diff.c about the diffstat reverts a bugfix made in v1.8.0 timeperiod, it seems.