Re: [PATCH v2] send-email: Net::SMTP::SSL is obsolete, use only when necessary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 31, 2017, 22:39 UTC
- Message-ID
- <xmqq7f0wabxn.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170531214634.GB81679@aiede.mtv.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 22 quoted lines
> Dennis Kaarsemaker wrote: > >> Net::SMTP itself can do the necessary SSL and STARTTLS bits just fine >> since version 1.28, and Net::SMTP::SSL is now deprecated. Since 1.28 >> isn't that old yet, keep the old code in place and use it when >> necessary. > > This broke git send-email for me. The error message is > > Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410. > > Is 1.28 the right minimum version? > > $ perl -e 'require Net::SMTP; print version->parse($Net::SMTP::VERSION); print "\n"' > 2.31 > $ grep VERSION /usr/share/perl/5.18.2/Net/SMTP.pm > use vars qw($VERSION @ISA); > $VERSION = "2.31"; > $ grep starttls /usr/share/perl/5.18.2/Net/SMTP.pm > $ dpkg-query -W perl > perl 5.18.2-2ubuntu1.1 >
Thanks.
Let's revert the merge for now until we know (this time for certain) what the minimum version is.