Re: [PATCH v2] send-email: Net::SMTP::SSL is obsolete, use only when necessary

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 31, 2017, 22:53 UTC
Message-ID: <20170531225348.GD81679@aiede.mtv.corp.google.com>
In-Reply-To: <xmqq7f0wabxn.fsf@gitster.mtv.corp.google.com>

Hi,

Jun 01, 2017 at 07:39:16AM +0900, Junio C Hamano wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

>> This broke git send-email for me.  The error message is
>>
>>   Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410.
>>
>> Is 1.28 the right minimum version?
>>
>>   $ perl -e 'require Net::SMTP; print version->parse($Net::SMTP::VERSION); print "\n"'

[...]

Show 8 quoted lines

>>   $ grep starttls /usr/share/perl/5.18.2/Net/SMTP.pm
>>   $ dpkg-query -W perl
>>   perl    5.18.2-2ubuntu1.1
>
> Thanks.
>
> Let's revert the merge for now until we know (this time for certain)
> what the minimum version is.

Thanks. I just sent http://public-inbox.org/git/20170531224415.GC81679@aiede.mtv.corp.google.com in response to another thread. That uses 3.01 as minimum version, since it is the minimum version imported to core perl with starttls support.

I haven't tried testing with historical Net::SMTP versions, though. Is there a git repository available with all Net::SMTP versions from CPAN, or is https://perl5.git.perl.org/perl.git as good as it gets?

Regards, Jonathan