Re: [PATCH v2 05/10] git.c: provide setup_auto_pager()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2017, 16:32 UTC
- Message-ID
- <xmqq7eyok1nw.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170731033429.dgftfeum6n3ddxua@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> But thinking on it, the most plausible case is something like:
>
> setup_auto_pager("foo", -1);
> ...
> /* fallback to some historical compatibility name */
> setup_auto_pager("bar", 0);
>
> And it's important for the "-1" there to be a true punt, and not do
> anything in commit_pager_choice(). So it's probably worth documenting
> the "-1" behavior as you did here as a possible value for "def".Thanks for reading it over. I agree that the "punt" behaviour is a sensible one in that use case, and I also agree that it would be good to explain it.