Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2017, 11:08 UTC
Message-ID: <xmqq7ew0zkqv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqefq92mgw.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> 	get_signoff () {
> 		git cat-file commit "$1" | sed -n -e '/^Signed-off-by: /p'
> 	}
>
> Some may say "cat-file can fail, and having it on the LHS of a pipe
> hides its failure", advocating for something like:
>
> 	get_signoff () {
> 		git cat-file commit "$1" >sign-off-temp &&
> 		sed -n -e '/^Signed-off-by: /p' sign-off-temp
> 	}

Actually we should use git itself for things like this, e.g.

	git -C dst show -s --pretty='format:%(trailers)' HEAD >actual &&
	test_cmp expect actual