Re: [PATCH] pull: pass --signoff/--no-signoff to "git merge"

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2017, 05:42 UTC
Message-ID: <xmqq60bk2a7t.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171012053002.GZ11004@valgrind.tremily.us>

"W. Trevor King" <wking@tremily.us> writes:

Show 10 quoted lines

> On Thu, Oct 12, 2017 at 10:17:51AM +0900, Junio C Hamano wrote:
>> "W. Trevor King" <wking@tremily.us> writes:
>> 
>> > Following 09c2cb87 (pull: pass --allow-unrelated-histories to "git
>> > merge", 2016-03-18) with the tests also drawing on 14d01b4f (merge:
>> > add a --signoff flag, 2017-07-04).
>> 
>> I cannot find a verb in the above.
>
> I'd meant it as either a continuation of the subject line, or with an

Never do that. The title should be able to stand on its own, and must not be an early part of incomplete sentence.

Show 5 quoted lines

> Much nicer, thanks.  I'll add a patch to v2 to make the same change to
> t7614.
> ...
> Sounds good.  I'll add a patch to v2 to make the same change to the
> existing t5521 --allow-unrelated-histories test.

Please don't, unless you are actively working on the features that they test. We do not have infinite amount of bandwidth to deal with changes for the sake of perceived consistency and no other real gain.