git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix comma splices

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 22, 2018, 23:23 UTC
Message-ID
<xmqq7es9jx63.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20180122230819.GB21604@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> (To be pedantic, these aren't comma splices. A comma splice joins two
> independent clauses with a comma and _without_ a conjunction).

Thanks for clearing up the "Huh?" I felt earlier when I threw the patch to "to look at later" bin after finding updated text for most of them read not much better than the original, at least to me.

So I am OK to take this patch (or an updated version), but the log message needs updating, I guess.

>   2. Is this Q_() here actually helping? It triggers on "ours + theirs"
>   ...
>      In fact, I don't think the singular case here can _ever_ trigger,
Exactly.
Previous: Jeff King
Message 3 of 3 in “Fix comma splices”
  1. Fix comma splicesfelipe@felipegasper.com, Jan 22, 2018
  2. Jeff KingJan 22, 2018
  3. Junio C HamanoJan 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.