From: Junio C Hamano Date: Mon, 22 Jan 2018 23:23:00 GMT Subject: Re: [PATCH] Fix comma splices Message-ID: In-Reply-To: <20180122230819.GB21604@sigill.intra.peff.net> Jeff King writes: > (To be pedantic, these aren't comma splices. A comma splice joins two > independent clauses with a comma and _without_ a conjunction). Thanks for clearing up the "Huh?" I felt earlier when I threw the patch to "to look at later" bin after finding updated text for most of them read not much better than the original, at least to me. So I am OK to take this patch (or an updated version), but the log message needs updating, I guess. > 2. Is this Q_() here actually helping? It triggers on "ours + theirs" > ... > In fact, I don't think the singular case here can _ever_ trigger, Exactly.