git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff: improve trimming preprocessing

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 6, 2018, 19:29 UTC
Message-ID
<xmqq7eqp3suv.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAPig+cRYsf161-Xomw7daj8XdEBxZAEQQRdOn4krRTpSAFkPOw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Tue, Mar 6, 2018 at 6:53 AM, Jun Wu <quark@fb.com> wrote:
>> xdiff-interface trims common suffix if ctxlen is 0. Teach it to also
>> trim common prefix, and trim less lines if ctxlen > 0. So it can benefit
>> the default diff command, as seen by profiling: [...]

I vaguely recall that we have tried this in the distant past, found that it produced incorrect result, and that is why we limit the optimization for no-context case.

Does anybody have an archive reference?
Previous: Eric SunshineNext: Jun Wu
Message 3 of 7 in “xdiff: improve trimming preprocessing”
  1. xdiff: improve trimming preprocessingJun Wu, Mar 6, 2018
  2. Eric SunshineMar 6, 2018
  3. Junio C HamanoMar 6, 2018
  4. Jun WuMar 6, 2018
  5. Jun WuMar 6, 2018
  6. Eric SunshineMar 7, 2018
  7. René ScharfeMar 7, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.