Re: [PATCH] xdiff: improve trimming preprocessing

From: René Scharfe <l.s.r@web.de>
Date: Mar 7, 2018, 14:36 UTC
Message-ID: <35faf81e-b604-d5b5-be51-bfe5cb9ec4cc@web.de>
In-Reply-To: <CAPig+cToTv063z-HB=8Y9LkpbqQaKCVJG_nU0Qd7O9ZdJY-p6g@mail.gmail.com>

Am 07.03.2018 um 10:36 schrieb Eric Sunshine:

Show 12 quoted lines

> On Tue, Mar 6, 2018 at 6:05 PM, Jun Wu <quark@fb.com> wrote:
>> Excerpts from Eric Sunshine's message of 2018-03-06 14:23:46 -0500:
>>> On Tue, Mar 6, 2018 at 6:53 AM, Jun Wu <quark@fb.com> wrote:
>>>> +  printf "x%.0s" {1..934} >>d # pad common suffix to 1024 bytes
>>>
>>> The expression {x..y} is not portable to non-POSIX shells.
>>
>> Is there a recommended way to generate a repetitive string?
>> Maybe `seq 1000 | sed 's/.*/x/'` ?
> 
> That seems reasonable, although you'd want to use the test suite's
> more portable test_seq rather than seq.

You could also use Perl's repetition operator (x):

	perl -e "print \"x\" x 934" >>d

It is a single command (only one fork()/exec()), simple, produces no extra newline characters and it's already used e.g. in t5300-pack-object.sh.

René