Re: [PATCH 1/2] git-credential-netrc: adapt to test framework for git

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2018, 09:43 UTC
Message-ID: <xmqq7eobkfrc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180509213634.5198-2-luis.marsano@gmail.com>

Luis Marsano <luis.marsano@gmail.com> writes:

> until this change, git-credential-netrc did not test in a repository
> this change reuses the main test framework, which provides such tests
> specific changes

Sorry, but I cannot quite parse what the above is trying to say.

Show 11 quoted lines

> - switch to Test::More module
> - use File::Basename & File::Spec::Functions
>
> Signed-off-by: Luis Marsano <luis.marsano@gmail.com>
> Acked-by: Ted Zlatanov <tzz@lifelogs.com>
> ---
>  contrib/credential/netrc/Makefile             |  4 +-
>  .../netrc/t-git-credential-netrc.sh           | 31 ++++++++
>  contrib/credential/netrc/test.pl              | 73 ++++++++++++-------
>  3 files changed, 78 insertions(+), 30 deletions(-)
>  create mode 100755 contrib/credential/netrc/t-git-credential-netrc.sh

Will queue, but may need to make the log message readable/understandable.

Thanks.