Re: [PATCH 1/2] git-credential-netrc: adapt to test framework for git

From: Luis Marsano <luis.marsano@gmail.com>
Date: May 14, 2018, 09:46 UTC
Message-ID: <20180514054601.5805@lmm-notebook.localdomain>
In-Reply-To: <xmqq7eobkfrc.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Luis Marsano <luis.marsano@gmail.com> writes:
> 
> > until this change, git-credential-netrc did not test in a repository
> > this change reuses the main test framework, which provides such tests
> > specific changes
> 
> Sorry, but I cannot quite parse what the above is trying to say.
>

[⋮]

Show 5 quoted lines

> 
> Will queue, but may need to make the log message
> readable/understandable.
> 
> Thanks.

Thank you, the rewrite https://public-inbox.org/git/20180512091728.4931-2-luis.marsano@gmail.com/ should be more intelligible. I welcome further criticisms if any.