Re: [PATCH v4 2/7] t/t7510: check the validation of the new config gpg.format

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2018, 21:31 UTC
Message-ID: <xmqq7eltmtv7.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2f806c4fa4454af59344f0f0e77d1ae8048aa841.1531831244.git.henning.schild@siemens.com>

Henning Schild <henning.schild@siemens.com> writes:

Show 20 quoted lines

> Test setting gpg.format to both invalid and valid values.
>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  t/t7510-signed-commit.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
> index 6e2015ed9..7bdad570c 100755
> --- a/t/t7510-signed-commit.sh
> +++ b/t/t7510-signed-commit.sh
> @@ -227,4 +227,13 @@ test_expect_success GPG 'log.showsignature behaves like --show-signature' '
>  	grep "gpg: Good signature" actual
>  '
>  
> +test_expect_success GPG 'check config gpg.format values' '
> +	test_config gpg.format openpgp &&
> +	git commit -S --amend -m "success" &&
> +	test_config gpg.format OpEnPgP &&
> +	test_must_fail git commit -S --amend -m "fail" &&

This second one is a good demonstration that the value for this variable is case sensitive.

> +	test_config gpg.format malformed &&
> +	test_must_fail git commit -S --amend -m "fail"

And there is no longer a good reason to try another one. Let's drop this last/third case.

> +'
> +
>  test_done