Re: [PATCH] t/t5534: do not unset GIT_COMMITTER_EMAIL for other tests
- From
Henning Schild <henning.schild@siemens.com>
- Date
- Jul 20, 2018, 08:28 UTC
- Message-ID
- <20180720102840.37f28d17@md1pvb1c.ad001.siemens.net>
- In-Reply-To
- <xmqqzhymdfo3.fsf@gitster-ct.c.googlers.com>
Am Thu, 19 Jul 2018 15:27:56 -0700 schrieb Junio C Hamano <gitster@pobox.com>:
Show 17 quoted lines
> Henning Schild <henning.schild@siemens.com> writes: > > > Looking at "what is cooking" i assume i should not add/fold this > > to/in the serien anymore. So it comes as a separate patch on top. > > Thanks. I only said: > > I think this round is mostly ready, except for a minor nit in the > last step. I do not mind merging this to 'next' and leave fixing > of the test to a later clean-up. > > meaing that I _do not mind_ merging the slightly broken one to > 'next' and fixing it with a follow-up (i.e. this patch), but fixing > with a replacement patch so that we pretend we never made a mistake > that needs fixing from the beginning is of course preferrable ;-) > > Let's squash this patch into the last one in the series.
Ok, just sent a v6 of 7/7.
Henning