git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: extend NO_TCLTK=NoThanks to cover docs

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 15, 2018, 18:07 UTC
Message-ID
<xmqq7ekrijw2.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<87lg97qzr4.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 25 quoted lines
>>>> +ifndef NO_TCLTK
>>>> +MAN1_TXT_WIP += gitk.txt
>>>> +MAN1_TXT = $(MAN1_TXT_WIP)
>>>> +else
>>>> +TCLTK_FILES += git-gui.txt
>>>> +TCLTK_FILES += gitk.txt
>>>> +TCLTK_FILES += git-citool.txt
>>>> +MAN1_TXT = $(filter-out \
>>>> +		$(TCLTK_FILES), \
>>>> +		$(MAN1_TXT_WIP))
>>>> +endif
>>
>> I didn't notice it when I read it for the first time, but asymmetry
>> between these two looks somewhat strange.  If we are adding gitk.txt
>> when we are not declining TCLTK based programs, why can we do
>> without adding git-gui and git-citool at the same time?  If we know
>> we must add gitk.txt when we are not declining TCLTK based programs
>> to MAN1_TXT_WIP in this section, it must mean that when we do not
>> want TCLTK based programs, MAN1_TXT_WIP would not have gitk.txt on
>> it, so why do we even need it on TCLTK_FILES list to filter it out?
>
> The only explicitly listed files are those that don't match the wildcard
> git-*.txt. Therefore if we want gitk.txt we need to explicitly list only
> it, but if we don't want the TCL programs we also need to list the ones
> that match git-*.txt.

Which means that gitk.txt does not have to be on TCLTK_FILES list, no?

Previous: Ævar Arnfjörð BjarmasonNext: Jonathan Nieder
Message 5 of 6 in “Makefile: extend NO_TCLTK=NoThanks to cover docs”
  1. Makefile: extend NO_TCLTK=NoThanks to cover docsÆvar Arnfjörð Bjarmason, Aug 15, 2018
  2. Junio C HamanoAug 15, 2018
  3. Junio C HamanoAug 15, 2018
  4. Ævar Arnfjörð BjarmasonAug 15, 2018
  5. Junio C HamanoAug 15, 2018
  6. Jonathan NiederAug 17, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.