Re: [PATCH] Makefile: extend NO_TCLTK=NoThanks to cover docs

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 17, 2018, 06:42 UTC
Message-ID: <20180817064259.GA131749@aiede.svl.corp.google.com>
In-Reply-To: <20180815151505.12011-1-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> Extend the NO_TCLTK=NoThanks flag to be understood by the
> Documentation Makefile.
>
> Before this change compiling and installing with NO_TCLTK would result
> in no git-gui, gitk or git-citool being installed, but their
> respective manual pages would still be installed.

Like Junio mentioned, what this commit message is missing is a description of why that is a bad thing.

E.g. is this affecting some distro or some end user? Are the docs taking up too much space? What is the motivation that leads to this patch?

(I may be a little more sympathetic to the goal than Junio was if I understood correctly, but I think it's useful and important to spell that goal out. When building for a distro with NO_PYTHON=YesPlease, my strategy was to simply rm the unwanted man pages after the fact in the packaging rules and that worked fine.)

[...]

Show 6 quoted lines

> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -1,5 +1,7 @@
>  # Guard against environment variables
>  MAN1_TXT =
> +MAN1_TXT_WIP =

It took me a while to understand this MAN1_TXT_WIP.

Could this just use MAN1_TXT and have the filtered one be MAN1_TXT_FILTERED? Since the latter gets a value using =, it doesn't need to be cleared up front.

It seems a little odd to see this specific to Tcl/Tk. Do other languages with NO_x options need the same treatment?

Curious, Jonathan