git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] mingw: replace MSVCRT's fstat() with a Win32-based implementation

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 25, 2018, 09:35 UTC
Message-ID
<xmqq7ei6gyh8.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20181024224047.GF6119@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 7 quoted lines
> Yeah, that behavior is quite old.  I'm surprised that Linux ever did
> that.
> ...
> I don't feel strongly either way.  I feel confident the rest of Git
> doesn't use that field, so I don't see any downsides to keeping it other
> than the slight overhead of populating it.  I just thought I'd ask in
> case there was something important I was missing.

OK, I'd consider that this part of the review settled for taking the patch as-is. Let's mark the topic for merging to 'next' soonish in the what's cooking report.

Thanks.
Previous: brian m. carlsonNext: Karsten Blees via GitGitGadget
Message 7 of 8 in “Use nanosecond-precision file times on Windows”
  1. 0/3 Use nanosecond-precision file times on WindowsJohannes Schindelin via GitGitGadget, Oct 23, 2018
  2. 1/3 mingw: factor out code to set stat() dataJohannes Schindelin via GitGitGadget, Oct 23, 2018
  3. 2/3 mingw: replace MSVCRT's fstat() with a Win32-based implementationKarsten Blees via GitGitGadget, Oct 23, 2018
  4. brian m. carlsonOct 24, 2018
  5. Johannes SchindelinOct 24, 2018
  6. brian m. carlsonOct 24, 2018
  7. Junio C HamanoOct 25, 2018
  8. 3/3 mingw: implement nanosecond-precision file timesKarsten Blees via GitGitGadget, Oct 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.