From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 25 Oct 2018 09:35:47 GMT
Subject: Re: [PATCH 2/3] mingw: replace MSVCRT's fstat() with a Win32-based implementation
Message-ID: <xmqq7ei6gyh8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181024224047.GF6119@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> Yeah, that behavior is quite old.  I'm surprised that Linux ever did
> that.
> ...
> I don't feel strongly either way.  I feel confident the rest of Git
> doesn't use that field, so I don't see any downsides to keeping it other
> than the slight overhead of populating it.  I just thought I'd ask in
> case there was something important I was missing.

OK, I'd consider that this part of the review settled for taking the
patch as-is.  Let's mark the topic for merging to 'next' soonish in
the what's cooking report.

Thanks.