Re: [PATCH v2 05/20] merge-recursive: remove useless parameter in merge_trees()

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2019, 19:37 UTC
Message-ID: <xmqq7e84oady.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190726155258.28561-6-newren@gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 7 quoted lines

> merge_trees() took a results parameter that would only be written when
> opt->call_depth was positive, which is never the case now that
> merge_trees_internal() has been split from merge_trees().  Remove the
> misleading and unused parameter from merge_trees().
>
> While at it, add some comments explaining how the output of
> merge_trees() and merge_recursive() differ.

Makes sense.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.