git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: learn to complete `git rebase --onto=`

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 13, 2019, 01:11 UTC
Message-ID
<xmqq7e44eg18.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191112180503.GB41101@generichostname>
Denton Liu <liu.denton@gmail.com> writes:
Show 13 quoted lines
> On Tue, Nov 12, 2019 at 01:46:33PM +0900, Junio C Hamano wrote:
>> Denton Liu <liu.denton@gmail.com> writes:
>> 
>> > Before, when there was a space, we'd start a new word and, as a result,
>> > fallback to __git_complete_refs() and `--onto` would be completed this
>> > way. However, now we match the `--*` case which does not know how to
>> > offer completions for refs.
>> 
>> Very well explained.  Thanks, will queue.
>
> Could you please queue this on the tip of
> 'dl/complete-rebase-and-archive' since it fixes a regression introduced
> in that branch?

The topic dl/complete-rebase-onto, which has this patch, is built directly on top of that topic. Since we may need to rewrite the patch when further review comments come in, I'd prefer to leave it separate from the other topic (which must not be rewritten) at least for now.

Thanks.
Previous: Denton Liu
Message 5 of 5 in “Bug in bash completion for git rebase --onto”
  1. Paul JollyNov 11, 2019
  2. completion: learn to complete `git rebase --onto=`Denton Liu, Nov 11, 2019
  3. Junio C HamanoNov 12, 2019
  4. Denton LiuNov 12, 2019
  5. Junio C HamanoNov 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.