Re: [PATCH] completion: learn to complete `git rebase --onto=`

From: Denton Liu <liu.denton@gmail.com>
Date: Nov 12, 2019, 18:05 UTC
Message-ID: <20191112180503.GB41101@generichostname>
In-Reply-To: <xmqqpnhxg0ra.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, Nov 12, 2019 at 01:46:33PM +0900, Junio C Hamano wrote:

Show 8 quoted lines

> Denton Liu <liu.denton@gmail.com> writes:
> 
> > Before, when there was a space, we'd start a new word and, as a result,
> > fallback to __git_complete_refs() and `--onto` would be completed this
> > way. However, now we match the `--*` case which does not know how to
> > offer completions for refs.
> 
> Very well explained.  Thanks, will queue.

Could you please queue this on the tip of 'dl/complete-rebase-and-archive' since it fixes a regression introduced in that branch?

Thanks,

Denton