git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RESEND PATCH v2 0/5] t: replace incorrect test_must_fail usage (part 6)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2020, 20:57 UTC
Message-ID
<xmqq7dvf3uwc.fsf@gitster.c.googlers.com>
In-Reply-To
<xmqqblkr3x6q.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
>> Changes since v1:
>>
>> * Add a code comment to force_color()
>>
>> * Do not allow nested env's in test_must_fail_acceptable()
>>
>> * Clean up the env-processing case code
>>
>> * Give an example on how to use `!`.
>
> Thanks for a resend.  Now part #5 is in 'master', I can queue these
> directly on top.

It seems that the patch series lacks coverage for t9400 where we have

test_expect_success 'cvs server does not run with vanilla git-shell' '
	(
		cd cvswork &&
		CVS_SERVER=$WORKDIR/remote-cvs &&
		export CVS_SERVER &&
		test_must_fail cvs log merge
	)
'

which obviously needs to be converted before we declare that it is a hard error to feed a non-git command to test_must_fail.

Previous: Junio C HamanoNext: Denton Liu
Message 25 of 29 in “t: replace incorrect test_must_fail usage (part 6)”
  1. 0/5 t: replace incorrect test_must_fail usage (part 6)Denton Liu, Jun 30, 2020
  2. 1/5 t3701: stop using `env` in force_color()Denton Liu, Jun 30, 2020
  3. Eric SunshineJun 30, 2020
  4. Junio C HamanoJun 30, 2020
  5. 3/5 t7107: don't use test_must_fail()Denton Liu, Jun 30, 2020
  6. 2/5 t5324: reorder `run_with_limited_open_files test_might_fail`Denton Liu, Jun 30, 2020
  7. 4/5 t9834: remove use of `test_might_fail p4`Denton Liu, Jun 30, 2020
  8. 5/5 test-lib-functions: restrict test_must_fail usageDenton Liu, Jun 30, 2020
  9. Eric SunshineJun 30, 2020
  10. Eric SunshineJun 30, 2020
  11. Denton LiuJun 30, 2020
  12. 0/5 t: replace incorrect test_must_fail usage (part 6)Denton Liu, Jul 1, 2020
  13. 4/5 t9834: remove use of `test_might_fail p4`Denton Liu, Jul 1, 2020
  14. 2/5 t5324: reorder `run_with_limited_open_files test_might_fail`Denton Liu, Jul 1, 2020
  15. 5/5 test-lib-functions: restrict test_must_fail usageDenton Liu, Jul 1, 2020
  16. 1/5 t3701: stop using `env` in force_color()Denton Liu, Jul 1, 2020
  17. 3/5 t7107: don't use test_must_fail()Denton Liu, Jul 1, 2020
  18. 0/5 t: replace incorrect test_must_fail usage (part 6)Denton Liu, Jul 7, 2020
  19. 1/5 t3701: stop using `env` in force_color()Denton Liu, Jul 7, 2020
  20. 5/5 test-lib-functions: restrict test_must_fail usageDenton Liu, Jul 7, 2020
  21. 4/5 t9834: remove use of `test_might_fail p4`Denton Liu, Jul 7, 2020
  22. 3/5 t7107: don't use test_must_fail()Denton Liu, Jul 7, 2020
  23. 2/5 t5324: reorder `run_with_limited_open_files test_might_fail`Denton Liu, Jul 7, 2020
  24. Junio C HamanoJul 7, 2020
  25. Junio C HamanoJul 7, 2020
  26. t9400: don't use test_must_fail with cvsDenton Liu, Jul 7, 2020
  27. Junio C HamanoJul 7, 2020
  28. Denton LiuJul 7, 2020
  29. Junio C HamanoJul 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.