Re: style(git-gui): Fix mixed tabs & spaces; Always use tabs.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2020, 19:26 UTC
Message-ID: <xmqq7dtq7a7w.fsf@gitster.c.googlers.com>
In-Reply-To: <20200822105616.68296-1-serg.partizan@gmail.com>

Serg Tereshchenko <serg.partizan@gmail.com> writes:

Show 25 quoted lines

> Hello.
>
> I want to improve styling of git-citool, so it supports dark themes.
> But first i want to remove "mixed indent warning" from my editor
> modeline.
>
> This patch does not change anything besides indents, and sometimes i
> replace
>
> ```tcl
> if {long ||
>     multiline ||
>     statement}
> ```
>
> with more readable
>
> ```tcl
> if {
>     long
>     || multiline
>     || statement
> }
> ```
> But only in lines with mixed indents.

You don't ever want to do that in a patch for "fix indentation" patch.

Besides, the comparison between these two styles is subjective, and you do not represent the majority view of who needs to work on the code in git-gui, so "with more readable" is not a very good justification to do so.

If the existing code in the whole file uses mixture of both styles, and one style is used overwhelmingly more than the other, a follow-up patch to adjust the style to one, with "consistency" as the justification, would be a good idea, though.

Thanks.