git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] style(git-gui): Fix mixed tabs & spaces; Prefer tabs.

From
Serg Tereshchenko <serg.partizan@gmail.com>
Date
Sep 9, 2020, 13:01 UTC
Message-ID
<20200909130136.39098-1-serg.partizan@gmail.com>
In-Reply-To
<20200909045108.j5ovnbk35cmghgcz@yadavpratyush.com>
Hi Pratyush,

Thanks for suggestion about scissors, i was wondering how to do this properly, i'll try it next time.

Show 8 quoted lines
> I'm not on board with this entire hunk. In many C projects (like Linux, 
> Git, etc) the "switch" and the "case" are on the same indent level. I 
> can see instances of this in almost every switch-case block in 
> git-gui.sh as well. We should stick to the local convention here and 
> drop this hunk.
> 
> I can make these changes locally and merge them so no need to re-roll... 
> unless you have any counter points that is.
I have no objections, please drop that hunk.

-- Regards, Serg Tereshchenko

Previous: Pratyush YadavNext: Pratyush Yadav
Message 5 of 6 in “style(git-gui): Fix mixed tabs & spaces; Always use tabs.”
  1. Serg TereshchenkoAug 22, 2020
  2. Junio C HamanoAug 22, 2020
  3. style(git-gui): Fix mixed tabs & spaces; Prefer tabs.Serg Tereshchenko, Aug 22, 2020
  4. Pratyush YadavSep 9, 2020
  5. Serg TereshchenkoSep 9, 2020
  6. Pratyush YadavSep 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.