Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2021, 19:59 UTC
Message-ID: <xmqq7dgq304m.fsf@gitster.g>
In-Reply-To: <20210812065234.71399-1-carenas@gmail.com>

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

Show 6 quoted lines

> e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,
> 2021-06-23) changed all calls to that action from v1 to v2, but there
> is still an open bug[1] that affects all nodejs actions and prevents
> its use in 32-bit linux (as used by the Linux32 container)
>
> move all dockerized jobs to use v1 that was build in C# and therefore

"was build -> was built", I would think.

Show 8 quoted lines

> doesn't have this problem which will otherwise manifest with confusing
> messages like:
>
>   /usr/bin/docker exec  0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c "cat /etc/*release | grep ^ID"
>   OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown
>
> [1] https://github.com/actions/runner/issues/1011
> ---

Not signed off.

Show 13 quoted lines

>  .github/workflows/main.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 47876a4f02..9dd41a1742 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -258,7 +258,7 @@ jobs:
>          - jobname: linux-musl
>            image: alpine
>          - jobname: Linux32
> -          image: daald/ubuntu32:xenial
> +          image: i386/ubuntu:xenial

Intended or accidental? At least it is not explained where this change comes from in the proposed log message.

Show 9 quoted lines

>      env:
>        jobname: ${{matrix.vector.jobname}}
>      runs-on: ubuntu-latest
> @@ -271,7 +271,7 @@ jobs:
>        if: failure()
>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v1

This one matches what the proposed log message says, switching from @v2 to @v1.

>        with:
>          name: failed-tests-${{matrix.vector.jobname}}
>          path: ${{env.FAILED_TEST_ARTIFACTS}}