Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Aug 12, 2021, 22:19 UTC
- Message-ID
- <CAPUEspg3ci4VVEU+ktDZgZkhykKbs9-+JmiOx_2CmOwFoYdMMw@mail.gmail.com>
- In-Reply-To
- <xmqq7dgq304m.fsf@gitster.g>
On Thu, Aug 12, 2021 at 12:59 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> > Carlo Marcelo Arenas Belón <carenas@gmail.com> writes: > > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > > index 47876a4f02..9dd41a1742 100644 > > --- a/.github/workflows/main.yml > > +++ b/.github/workflows/main.yml > > @@ -258,7 +258,7 @@ jobs: > > - jobname: linux-musl > > image: alpine > > - jobname: Linux32 > > - image: daald/ubuntu32:xenial > > + image: i386/ubuntu:xenial > > Intended or accidental?
yes!.
It was intended but more as an RFC, because I couldn't find an explanation on what was the advantage of using this 5 year old unofficial image when there was an equivalent official one that had been updated just last month.
It was accidental, because I didn't realize I hadn't updated the log message and it isn't needed to fix the regression which was the main focus anyway.
> At least it is not explained where this > change comes from in the proposed log message.
The advantages of using an official image will be :
* more likely to be cached and therefore less likely to fail the job * easier to move to a newer version (specially considering 16.04 is EOL)
Would it be better to drop or document it for v2?
Carlo