Re: [PATCH v2] commit-graph: Fix missing closedir in expire_commit_graphs

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2022, 17:41 UTC
Message-ID: <xmqq7d1zb6ta.fsf@gitster.g>
In-Reply-To: <4f1cf64e-2864-a979-6f75-d9d4148d57da@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 21 quoted lines

> On 9/19/2022 10:14 AM, Miaoqian Lin wrote:
>> The function calls opendir() but missing the corresponding
>> closedir() before exit the function.
>> Add missing closedir() to fix it.
>
> Thanks for the patch, Miaoqian.
>
> I only have a very tiny nitpick with the line breaks in your
> commit message. Either the "Add missing..." sentence should
> start immediately after the previous sentence or have another
> line break between the paragraphs. This shouldn't merit a
> re-roll, but keep it in mind for future contributions.
>
>>  out:
>> +	if(dir)
>> +		closedir(dir);
>>  	strbuf_release(&path);
>>  }
>
> This change looks correct to me. Thanks!
> -Stolee

Thanks, both.  Looking good.