Re: [PATCH v2] commit-graph: Fix missing closedir in expire_commit_graphs

From: Derrick Stolee <derrickstolee@github.com>
Date: Sep 19, 2022, 15:04 UTC
Message-ID: <4f1cf64e-2864-a979-6f75-d9d4148d57da@github.com>
In-Reply-To: <20220919141441.5644-1-linmq006@gmail.com>

On 9/19/2022 10:14 AM, Miaoqian Lin wrote:

> The function calls opendir() but missing the corresponding
> closedir() before exit the function.
> Add missing closedir() to fix it.

Thanks for the patch, Miaoqian.

I only have a very tiny nitpick with the line breaks in your commit message. Either the "Add missing..." sentence should start immediately after the previous sentence or have another line break between the paragraphs. This shouldn't merit a re-roll, but keep it in mind for future contributions.

Show 5 quoted lines

>  out:
> +	if(dir)
> +		closedir(dir);
>  	strbuf_release(&path);
>  }

This change looks correct to me. Thanks! -Stolee