git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 26, 2023, 17:24 UTC
Message-ID
<xmqq7ctytv2y.fsf@gitster.g>
In-Reply-To
<ZElHNTiFCblfIDEe@ugly>
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> ping!
>
> (also on three other unanswered patches from the same day.)
I would be a wrong person to ping.  
    $ git shortlog -n -s --since=18.months --no-merges master -- t/lib-rebase.sh
         2	Phillip Wood
         1	Derrick Stolee

Running "git blame" on the lines the patch touched may give you folks who may know better than these two but those who made contributions long time ago whose contributions still survive to this day may no longer be around in the project, so your mileage may vary.

"git blame" for the line that uses "action=\&" finds 5dcdd740 (t/lib-rebase: prepare for testing `git rebase --rebase-merges`, 2019-07-31) and explains why "pick" was changed to "\&", so adding the author of that patch to the list of people you ask reviews for may also be a good idea.

HTH for you to find appropriate reviewers better next time.
Thanks.
Previous: Oswald BuddenhagenNext: Felipe Contreras
Message 3 of 22 in “t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()”
  1. t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Mar 23, 2023
  2. Oswald BuddenhagenApr 26, 2023
  3. Junio C HamanoApr 26, 2023
  4. Felipe ContrerasMay 2, 2023
  5. Phillip WoodMay 17, 2023
  6. 0/3 t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Aug 7, 2023
  7. 1/3 t/lib-rebase: set_fake_editor(): fix recognition of reset's short commandOswald Buddenhagen, Aug 7, 2023
  8. Junio C HamanoAug 7, 2023
  9. 3/3 t/lib-rebase: improve documentation of set_fake_editor()Oswald Buddenhagen, Aug 7, 2023
  10. Phillip WoodAug 9, 2023
  11. 0/1 t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Aug 9, 2023
  12. 1/1 t/lib-rebase: improve documentation of set_fake_editor()Oswald Buddenhagen, Aug 9, 2023
  13. Junio C HamanoAug 9, 2023
  14. Phillip WoodAug 10, 2023
  15. Junio C HamanoAug 10, 2023
  16. Junio C HamanoAug 9, 2023
  17. Oswald BuddenhagenAug 10, 2023
  18. Junio C HamanoAug 10, 2023
  19. Junio C HamanoAug 10, 2023
  20. 2/3 t/lib-rebase: set_fake_editor(): handle FAKE_LINES more consistentlyOswald Buddenhagen, Aug 7, 2023
  21. Junio C HamanoAug 7, 2023
  22. Phillip WoodAug 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.