git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] t/lib-rebase: improve documentation of set_fake_editor()

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 10, 2023, 15:49 UTC
Message-ID
<xmqq1qgaj3sj.fsf@gitster.g>
In-Reply-To
<a2830ab8-e938-56e8-4f28-074262c95ed8@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 22 quoted lines
> Hi Oswald
>
> On 09/08/2023 18:15, Oswald Buddenhagen wrote:
>> Firstly, make it reflect better what actually happens. Not omitting some
>> possibilities makes it easier to fully exploit them, and not
>> contradicting the implementation makes it easier to grok and thus modify
>> the code.
>
> Thanks for expanding this first point, the new message looks fine to
> me. The code changes look good apart from one change in the that got
> missed.
>
>> -#   "<lineno>" -- add a "pick" line with the SHA1 taken from the
>> -#       specified line.
>> +#   "<cmd>" -- override the command for the next line specification. Can be
>> +#       "pick", "squash", "fixup[_-(c|C)]", "edit", "reword", "drop",
>> +#       "merge[_-{c|C}_<rev>]", or "bad" for an invalid command.
>
> This is still using "{}" in the merge documentation rather than "()"
> like the new fixup docs.
>
> Thanks
Ah, thanks for sharp eyes.  I can locally tweak these two bytes ;-)
Previous: Phillip WoodNext: Junio C Hamano
Message 15 of 22 in “t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()”
  1. t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Mar 23, 2023
  2. Oswald BuddenhagenApr 26, 2023
  3. Junio C HamanoApr 26, 2023
  4. Felipe ContrerasMay 2, 2023
  5. Phillip WoodMay 17, 2023
  6. 0/3 t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Aug 7, 2023
  7. 1/3 t/lib-rebase: set_fake_editor(): fix recognition of reset's short commandOswald Buddenhagen, Aug 7, 2023
  8. Junio C HamanoAug 7, 2023
  9. 3/3 t/lib-rebase: improve documentation of set_fake_editor()Oswald Buddenhagen, Aug 7, 2023
  10. Phillip WoodAug 9, 2023
  11. 0/1 t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()Oswald Buddenhagen, Aug 9, 2023
  12. 1/1 t/lib-rebase: improve documentation of set_fake_editor()Oswald Buddenhagen, Aug 9, 2023
  13. Junio C HamanoAug 9, 2023
  14. Phillip WoodAug 10, 2023
  15. Junio C HamanoAug 10, 2023
  16. Junio C HamanoAug 9, 2023
  17. Oswald BuddenhagenAug 10, 2023
  18. Junio C HamanoAug 10, 2023
  19. Junio C HamanoAug 10, 2023
  20. 2/3 t/lib-rebase: set_fake_editor(): handle FAKE_LINES more consistentlyOswald Buddenhagen, Aug 7, 2023
  21. Junio C HamanoAug 7, 2023
  22. Phillip WoodAug 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.