Re: [PATCH v2] pretty: add %(decorate[:<options>]) format

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2023, 01:05 UTC
Message-ID: <xmqq7cqydo5v.fsf@gitster.g>
In-Reply-To: <xmqqmszudtih.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> I'll stop here. After skimming the changes to the test, I think this
> single patch should be split into separate steps.  Perhaps the split
> should go like this:
> ...
> Thanks.

Oh, sorry that I forgot to add one thing.

Overall, the patch seems to be done very well when viewed as a whole. Thanks for working on it.

It is just I cannot be as confident as I would like to be in my review when the single patch does several different things at once. If it were split in steps, each step focusing on doing a single thing well and describing well what it does and why, reviewers can be more confident that they did not miss something important in the patch(es).

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.