Re: [PATCH v2] pretty: add %(decorate[:<options>]) format
- From
Andy Koppe <andy.koppe@gmail.com>
- Date
- Aug 11, 2023, 18:59 UTC
- Message-ID
- <CAHWeT-ZA8f-TGRwDHixAvi5kddVBbuK8LpVGJ9cjYZMsMk5ODw@mail.gmail.com>
- In-Reply-To
- <kl6l351j22dr.fsf@chooglen-macbookpro.roam.corp.google.com>
On Wed, 19 Jul 2023 at 19:16, Glen Choo wrote:
Show 5 quoted lines
> As a micro-nit: there's some useful context behind your chosen design in > [1]. It would have been useful to link to it in the `---` context, or > perhaps send this series as v3 and v4 to [1]. > > [1] https://lore.kernel.org/git/20230712110732.8274-1-andy.koppe@gmail.com/
Point taken.
> > + strbuf_expand(&sb, val, strbuf_expand_literal_cb, NULL); > > strbuf_expand() got removed in 'master' recently, so this should be > rebased.
Done. I think I had started off main, wrongly assuming that it's the same as master.
Thanks again, Andy