Re: [PATCH v3 1/7] rebase -i: move unlink() calls

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 1, 2023, 19:31 UTC
Message-ID: <xmqq7cqeblut.fsf@gitster.g>
In-Reply-To: <48fefaf0-6a31-0518-3424-73d93343f1d8@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> The files will never exist when the "if TODO_BREAK" is executed
> because we've removed them before entering the loop and as I tried and
> seemly failed to explain in the commit message they are only created
> when we're about to break out of the loop.

Specifically, they are not created when we voluntarily leave the loop via TODO_BREAK. They are created when we leave the loop via the other exit paths (e.g. path_message may be created from MERGE_MSG in error_with_patch() but the control flow to reach error_with_patch() in the loop would break out of the loop without ever reaching the TODO_BREAK codepath).

Or something like that?  I didn't follow thru the other two files.

OK. I am slow to read and understand a patch from more than 3 months ago X-<; sorry for the confusion.

Thanks.