Re: [PATCH v3 0/7] rebase -i: impove handling of failed commands

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Aug 9, 2023, 13:08 UTC
Message-ID: <dd07a578-9a8e-062d-11f8-7c969b026cb3@gmail.com>
In-Reply-To: <xmqq8rat6qou.fsf@gitster.g>

On 02/08/2023 23:10, Junio C Hamano wrote:

Show 10 quoted lines

> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>>    sequencer: factor out part of pick_commits()
>>    rebase: fix rewritten list for failed pick
>>    rebase --continue: refuse to commit after failed command
>>    rebase -i: fix adding failed command to the todo list
> 
> I'd really prefer to see the latter half of the series reviewed
> (both for the design and its implementation) by those who have more
> stake in the sequencer code than myself.

Dscho do you think you will have time to look at the last four patches after 2.42.0 is released?

Many Thanks

Phillip

Show 6 quoted lines

> I just noticed that we have a question on the last step left
> unanswered since the very initial iteration.
> 
> cf. https://lore.kernel.org/git/f05deb00-1bcd-9e05-739f-6a30d6d8cf3b@gmx.de/
> 
> Thanks.