Re: [PATCH v4 1/1] [PATCH] t9117: prefer test_path_* helper functions

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2024, 17:22 UTC
Message-ID: <xmqq7cihrjxj.fsf@gitster.g>
In-Reply-To: <20240304095436.56399-2-shejialuo@gmail.com>

shejialuo <shejialuo@gmail.com> writes:

> test -(e|d) does not provide a nice error message when we hit test
> failures, so use test_path_exists, test_path_is_dir instead.

OK.

>
> Signed-off-by: shejialuo <shejialuo@gmail.com>
> ---

Just for the next single-patch topic you'd work on, here below the three-dash line is where you may mention what's different between the previous iteration and this one, if you wanted to, instead of having a separate cover-letter message.

>  t/t9117-git-svn-init-clone.sh | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

The patch looks good to me. Thanks (and thanks for all the reviewers of the previous rounds).