Re: [PATCH] SoC 2024: clarify `test_path_is_*` conversion microproject
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Mar 4, 2024, 13:42 UTC
- Message-ID
- <CAP8UFD2Qzw8p5dTjTAjuKaSoHu22LBcJGUf3PG-NaK5CZOX0fw@mail.gmail.com>
- In-Reply-To
- <84995a068640c72c8f17406ffa0441c7fdba4bdc.1709543804.git.ps@pks.im>
On Mon, Mar 4, 2024 at 10:17 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 8 quoted lines
> > One of our proposed microprojects is to convert instances of `test -e` > and related functions to instead use `test_path_exists` or similar. This > conversion is only feasible when `test -e` is not used as part of a > control statement, as the replacement is used to _assert_ a condition > instead of merely testing for it. > > Clarify the microproject's description accordingly.
Applied and pushed, thanks!
I wonder if it would be better to create a PR in https://github.com/git/git.github.io/ and perhaps just send a link to it, rather than sending patches to the mailing list, as patches on the mailing list could be mistaken by tools and perhaps people as applying to the Git code base.