git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t0018: remove leftover debugging cruft

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 1, 2024, 18:51 UTC
Message-ID
<xmqq7cd0ulen.fsf_-_@gitster.g>
In-Reply-To
<xmqqbk2cum5o.fsf@gitster.g>

The actual file is copied out to /tmp, presumably so that the tester can inspect it after the test is done, which may have been a useful debugging aid.

But in the final shape of the test suite, such a code should not exist. We cannot even assume that we are allowed to write into /tmp (our TMPDIR may not even be pointing at it) or read from it for that matter.

Noticed-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t0018-advice.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh
index b02448ea16..040a08be07 100755
--- a/t/t0018-advice.sh
+++ b/t/t0018-advice.sh
@@ -93,7 +93,6 @@ EOF
 		>README &&
 		GIT_ADVICE=true git status
 	) >actual &&
-	cat actual > /tmp/actual &&
 	test_cmp expect actual
 '
 
-- 
2.46.0-179-g92bab5172e
Previous: Junio C HamanoNext: rsbecker@nexbridge.com
Message 3 of 6 in “[Bug] Temp file use in t0018.6”
  1. rsbecker@nexbridge.comAug 1, 2024
  2. Junio C HamanoAug 1, 2024
  3. t0018: remove leftover debugging cruftJunio C Hamano, Aug 1, 2024
  4. rsbecker@nexbridge.comAug 1, 2024
  5. rsbecker@nexbridge.comAug 1, 2024
  6. Jeff KingAug 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.