RE: [PATCH] t0018: remove leftover debugging cruft

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Aug 1, 2024, 18:53 UTC
Message-ID: <02e401dae444$23172780$69457680$@nexbridge.com>
In-Reply-To: <xmqq7cd0ulen.fsf_-_@gitster.g>

On Thursday, August 1, 2024 2:51 PM, Junio C Hamano wrote:

>The actual file is copied out to /tmp, presumably so that the tester can

inspect it

>after the test is done, which may have been a useful debugging aid.
>
>But in the final shape of the test suite, such a code should not exist.  We

cannot

>even assume that we are allowed to write into /tmp (our TMPDIR may not even

be

Show 9 quoted lines

>pointing at it) or read from it for that matter.
>
>Noticed-by: Randall S. Becker <rsbecker@nexbridge.com>
>Signed-off-by: Junio C Hamano <gitster@pobox.com>
>---
> t/t0018-advice.sh | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh index

b02448ea16..040a08be07

Show 13 quoted lines

>100755
>--- a/t/t0018-advice.sh
>+++ b/t/t0018-advice.sh
>@@ -93,7 +93,6 @@ EOF
> 		>README &&
> 		GIT_ADVICE=true git status
> 	) >actual &&
>-	cat actual > /tmp/actual &&
> 	test_cmp expect actual
> '
>
>--
>2.46.0-179-g92bab5172e

Verified to work correctly. Thanks.