Re: [PATCH v4] t: port helper/test-oid-array.c to unit-tests/t-oid-array.c
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 4, 2024, 15:01 UTC
- Message-ID
- <xmqq7cbrea40.fsf@gitster.g>
- In-Reply-To
- <CAP8UFD0NMCUeFpQmLzXZmTUQQjQh5Dk79QxxMH_GN62w8ZC6YQ@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 24 quoted lines
> On Sun, Sep 1, 2024 at 11:27 PM Ghanshyam Thakkar > <shyamthakkar001@gmail.com> wrote: >> >> helper/test-oid-array.c along with t0064-oid-array.sh test the >> oid-array.h API, which provides storage and processing >> efficiency over large lists of object identifiers. >> >> Migrate them to the unit testing framework for better runtime >> performance and efficiency. As we don't initialize a repository >> in these tests, the hash algo that functions like oid_array_lookup() >> use is not initialized, therefore call repo_set_hash_algo() to >> initialize it. And init_hash_algo():lib-oid.c can aid in this >> process, so make it public. >> >> Mentored-by: Christian Couder <chriscool@tuxfamily.org> >> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> >> Helped-by: Phillip Wood <phillip.wood123@gmail.com> >> Signed-off-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com> >> --- > > It would have been nice to briefly summarize here the changes compared > to v3. On the other hand they are small enough and this version > addresses all the suggestions that were made previously and looks good > to me, so I think it is good to go.
I only checked the changes sine the previous round myself, and didn't see anything questionable.
Let me mark the topic for 'next' soonish.
Thanks for polishing the topic, both of you.