Re: [GSoC][PATCH] t: port helper/test-oid-array.c to unit-tests/t-oid-array.c

From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Aug 3, 2024, 13:31 UTC
Message-ID: <D36BBC5EWOVX.1CERSXF01H5JI@gmail.com>
In-Reply-To: <db2f97b6-a06e-470f-b1f9-60a78a0a2a7f@gmail.com>

Hi Phillip,

Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 5 quoted lines

> On 03/07/2024 04:46, Ghanshyam Thakkar wrote:
> > Note: Once 'rs/unit-tests-test-run' is merged to atleast next, I plan to
> > replace these internal function used in TEST_LOOKUP() with TEST_RUN().
>
> Nice idea

I think the consensus on the 'TEST_RUN()' (which is now 'if_test()') would take a bit more time and since the v2 removes the use of internal functions anyways, I think we should not have to wait for 'if_test()' anymore (other things like declaring input varibles inside the 'if_test()' block can be addressed as an incremental patch once 'if_test()' gets merged). And I've addressed all your other review points in v2 as well.

Link to v2: https://lore.kernel.org/git/20240803132206.72166-1-shyamthakkar001@gmail.com/

Thanks.