Re: [PATCH v6 0/2] repo: add --keys and rename "keyvalue" to "lines"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 14, 2026, 18:14 UTC
- Message-ID
- <xmqq7bsfgpkv.fsf@gitster.g>
- In-Reply-To
- <20260214005818.37349-1-lucasseikioshiro@gmail.com>
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
Show 13 quoted lines
> This v6 addresses these issues raised by Patrick:
>
> - It renames `FORMAT_LINES` to `FORMAT_NEWLINE_TERMINATED`
> - Change the commit messsage of the first patch (I'm using Patrick's
> suggestion)
> - It capitalizes the new paragraphs
>
> There was a discussion about the name of the new format ("lines" vs
> "newline") [1]. Personally I prefer "lines" instead of "newline" because
> I understand the --format flag expects a format name (e.g. `table`,
> `lines`) instead of the delimiter, being `nul` only a short form of
> "nul-terminated". But, of course, I'm open to other opinions about it
> :-).I'll refrain from commenting on this part, as I am not good at naming ;-)
Changes relative to the previous round look all good. Will replace.
Let's mark it for 'next'.
Thanks.