git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 23, 2026, 17:59 UTC
Message-ID
<xmqq7bkbc0h5.fsf@gitster.g>
In-Reply-To
<CABPp-BFadjqtOB_9cYkrs9UBgTp0hQxu4oiV_yqzYOuiu6g45w@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 9 quoted lines
> Longer term, I wonder whether plain "git commit" should be rejected
> while resolving conflicts for rebase, am, cherry-pick, and revert,
> with users directed to the corresponding "--continue" command.  Plain
> commit has a surprising collection of behaviors:
> ...
> workflow, but I think plain "git commit" should eventually be
> disallowed as a way to resolve conflicts for other commands.
>
> That's post-2.56 work.

I would say castrating "git commit" so that it can only do a plain vanilla committing, while it may be a very good move from everything you said above, is post-3.0, not post-2.56, work ;-).

> For now I think either reverting (and trying
> again after the release), or recording HEAD in stopped-head seems
> preferable to relying on MERGE_MSG.

Between the two I'd say giving us a chance for a clean start is far more preferrable than repeating "Patrick thought of MERGE_MSG and after a few hours Phillip and Elijah thought of a more robust new mechanism. Let's hope there is no more holes found in the newly proposed mechanism in another few hours" after -rc2 got tagged.

Previous: Elijah NewrenNext: Patrick Steinhardt
Message 9 of 13 in “builtin/rebase: allow user to amend committed conflicts again”
  1. builtin/rebase: allow user to amend committed conflicts againPatrick Steinhardt, Sep 23, 2026
  2. Phillip WoodSep 23, 2026
  3. Phillip WoodSep 23, 2026
  4. Junio C HamanoSep 23, 2026
  5. Elijah NewrenSep 23, 2026
  6. Johannes SixtSep 24, 2026
  7. Jiang XinSep 27, 2026
  8. Elijah NewrenSep 23, 2026
  9. Junio C HamanoSep 23, 2026
  10. Patrick SteinhardtSep 23, 2026
  11. Junio C HamanoSep 23, 2026
  12. Patrick SteinhardtSep 23, 2026
  13. Elijah NewrenSep 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.