git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH REGRESSION] builtin/rebase: allow user to amend committed conflicts again

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Sep 23, 2026, 14:22 UTC
Message-ID
<24cc4bcc-1d26-46f5-a502-ba673713f4f0@gmail.com>
In-Reply-To
<c12d2ac3-5263-4301-aa64-a311a343dd40@gmail.com>
On 23/09/2026 15:02, Phillip Wood wrote:
Show 12 quoted lines
> On 23/09/2026 14:16, Patrick Steinhardt wrote:
>> Instead, use the existence of "MERGE_MSG" to figure out whether the user
>> has already resolved and committed the conflict. It feels somewhat fishy
>> to base our decisions on the existence of that particular file, as it
>> really is only a proxy for what we are actually after. 
> 
> I think that's probably the best we can do. If, after committing a 
> conflict resolution from "git rebase", the user runs a merge/cherry- 
> pick/revert that has conflicts, then "MERGE_MSG" will also exist, but we 
> don't want them to amend that case either so it should be fine.
> 
> The code changes look good,

Let me rephrase that. The code changes look good for "git rebase", but do we have a similar problem with "cherry-pick", "merge" and "revert"?

Thanks
Phillip
Previous: Phillip WoodNext: Junio C Hamano
Message 3 of 13 in “builtin/rebase: allow user to amend committed conflicts again”
  1. builtin/rebase: allow user to amend committed conflicts againPatrick Steinhardt, Sep 23, 2026
  2. Phillip WoodSep 23, 2026
  3. Phillip WoodSep 23, 2026
  4. Junio C HamanoSep 23, 2026
  5. Elijah NewrenSep 23, 2026
  6. Johannes SixtSep 24, 2026
  7. Jiang XinSep 27, 2026
  8. Elijah NewrenSep 23, 2026
  9. Junio C HamanoSep 23, 2026
  10. Patrick SteinhardtSep 23, 2026
  11. Junio C HamanoSep 23, 2026
  12. Patrick SteinhardtSep 23, 2026
  13. Elijah NewrenSep 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.