git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] environment: move line ending config variables into repo_config_values

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 3, 2026, 17:01 UTC
Message-ID
<xmqq7bitc0hu.fsf@gitster.g>
In-Reply-To
<aumOHhbTVW0bT3We@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 15 quoted lines
> On Mon, Oct 26, 2026 at 08:53:57AM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>> 
>> > While these patches _look_ like they libify Git more, they actually do
>> > the exact opposite right now and tie us more and more to
>> > `the_repository`. So I'm inclined to say that we should hold off merging
>> > these patches until we fix that issue, or otherwise we paint ourselves
>> > into a corner.
>> 
>> Could you please volunteer to add a quick patch to add a comment
>> next to the problematic structure to tell people stop moving things
>> there (for now) and point at the message I am responding to?
>
> Sorry, I planned to do that but haven't yet gotten around to it. But I
> see that you've sent it by now via [1]. Thanks!

Ah, I completely forgot about this exchange when I did [1] myself. Anyway, I'll take it as an Acked-by for it.

Thanks.
>
> Patrick
>
> [1]: <xmqqh5hzjdwr.fsf_-_@gitster.g> 
Previous: Patrick Steinhardt
Message 11 of 11 in “environment: move line ending config variables into repo_config_values”
  1. 0/4 environment: move line ending config variables into repo_config_valuesAniket Gupta, Oct 24, 2026
  2. 1/4 convert: pass 'repo' to the working tree conversion functionsAniket Gupta, Oct 24, 2026
  3. 2/4 environment: move auto_crlf into repo_config_valuesAniket Gupta, Oct 24, 2026
  4. 3/4 environment: move core_eol into repo_config_valuesAniket Gupta, Oct 24, 2026
  5. 4/4 environment: move global_conv_flags_eol into repo_config_valuesAniket Gupta, Oct 24, 2026
  6. Patrick SteinhardtOct 26, 2026
  7. Aniket GuptaOct 26, 2026
  8. Patrick SteinhardtOct 26, 2026
  9. Junio C HamanoOct 26, 2026
  10. Patrick SteinhardtNov 3, 2026
  11. Junio C HamanoNov 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.