From: Junio C Hamano Date: Tue, 03 Nov 2026 17:01:49 GMT Subject: Re: [PATCH 0/4] environment: move line ending config variables into repo_config_values Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Mon, Oct 26, 2026 at 08:53:57AM -0700, Junio C Hamano wrote: >> Patrick Steinhardt writes: >> >> > While these patches _look_ like they libify Git more, they actually do >> > the exact opposite right now and tie us more and more to >> > `the_repository`. So I'm inclined to say that we should hold off merging >> > these patches until we fix that issue, or otherwise we paint ourselves >> > into a corner. >> >> Could you please volunteer to add a quick patch to add a comment >> next to the problematic structure to tell people stop moving things >> there (for now) and point at the message I am responding to? > > Sorry, I planned to do that but haven't yet gotten around to it. But I > see that you've sent it by now via [1]. Thanks! Ah, I completely forgot about this exchange when I did [1] myself. Anyway, I'll take it as an Acked-by for it. Thanks. > > Patrick > > [1]: