Re: [PATCHv2] mailmap: handle mailmap blobs without trailing newlines
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 28, 2013, 19:39 UTC
- Message-ID
- <xmqq61upa9m3.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20130828014138.GA30623@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> This makes the code simpler and shorter (because we don't > have to correlate strchrnul with the length calculation), > correct (because the code with the off-by-one just goes > away), and more efficient (we can drop the extra allocation > we needed to create NUL-terminated strings for each line, > and just terminate in place).
Nice. Will queue. Thanks.