From: Junio C Hamano Date: Wed, 28 Aug 2013 19:39:00 GMT Subject: Re: [PATCHv2] mailmap: handle mailmap blobs without trailing newlines Message-ID: In-Reply-To: <20130828014138.GA30623@sigill.intra.peff.net> Jeff King writes: > This makes the code simpler and shorter (because we don't > have to correlate strchrnul with the length calculation), > correct (because the code with the off-by-one just goes > away), and more efficient (we can drop the extra allocation > we needed to create NUL-terminated strings for each line, > and just terminate in place). Nice. Will queue. Thanks.