Re: [PATCHv3 1/3] git-p4: add failing test for P4EDITOR handling

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2015, 19:54 UTC
Message-ID: <xmqq617nnhxk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1432074198-13806-2-git-send-email-luke@diamand.org>

Luke Diamand <luke@diamand.org> writes:

Show 6 quoted lines

> +
> +test_expect_failure 'EDITOR has options' '
> +# Check that the P4EDITOR argument can be given command-line
> +# options, which git-p4 will then pass through to the shell.
> +test_expect_success 'EDITOR has options' '
> +	git p4 clone --dest="$git" //depot &&

Oops? I assume that the one before the comment should go and this one is

	test_expect_failure 'Editor with an option' '

or something.

Show 15 quoted lines

> +	test_when_finished cleanup_git &&
> +	(
> +		cd "$git" &&
> +		echo change >file1 &&
> +		git commit -m "change" file1 &&
> +		P4EDITOR=": >\"$git/touched\" && test-chmtime +5" git p4 submit &&
> +		test_path_is_file "$git/touched"
> +	)
> +'
> +
> +test_expect_success 'kill p4d' '
> +	kill_p4d
> +'
> +
> +test_done